Fix delivery_whitelist regex #5676
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -140,11 +140,11 @@ by adding the ``delivery_whitelist`` option: | |||
| delivery_whitelist: | |||
| # all email addresses matching this regex will *not* be | |||
| # redirected to dev@example.com | |||
| - "/@specialdomain.com$/" | |||
| - "/@specialdomain[.]com$/" | |||
There was a problem hiding this comment.
imho we should rather escape the period with a backslash
There was a problem hiding this comment.
If I am not mistaken, evaluating a character class is more expensive than evaluating a single character.
There was a problem hiding this comment.
@gonzalovilaseca although I can't provide a solid reasoning for this, I agree with @xabbuh here. When escaping just one character, I find it "better" to use the backslash instead of the other notation:
- "/@specialdomain[.]com$/"
- "/@specialdomain\.com$/"There was a problem hiding this comment.
ok, will update PR
Terminate the `tip` directive with a blank line.
…ated position of depreciation notes
(committed by weaverryan, original credit to the author on this commit)
|
Moved to #5684 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.